On 15/03/18 07:52, Jan Beulich wrote: >>>> On 14.03.18 at 19:31, <andrew.coop...@citrix.com> wrote: >> On 14/03/18 18:19, julien.gr...@arm.com wrote: >>> From: Wei Liu <wei.l...@citrix.com> >>> >>> The function is called to fill in page table entries in >>> populate_pt_range. Skip incrementing mfn if it is invalid. >>> >>> Signed-off-by: Wei Liu <wei.l...@citrix.com> >> Remind me what the purpose of this patch is? > This is in preparation to switch callers to pass INVALID_MFN > instead of zero for non-present mappings. The incrementing > from zero was wrong here already (but couldn't be as easily > avoided, to not cause problems with possible legitimate uses of > MFN 0), but incrementing (and wrapping) from INVALID_MFN is > (imo) even worse, which is why I had asked the conversion to > INVALID_MFN to not be done without this change.
Yes. My reply was a (clearly too) thinly veiled hint that a sentence to this effect should be in the commit message. The code itself is fine. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
