>>> Andrew Cooper <andrew.coop...@citrix.com> 03/09/18 6:06 PM >>> >On 09/03/18 17:00, Jan Beulich wrote: >>>>> On 09.03.18 at 14:18, <andrew.coop...@citrix.com> wrote: >>> --- a/xen/arch/x86/domain.c >>> +++ b/xen/arch/x86/domain.c >>> @@ -426,8 +426,8 @@ static bool emulation_flags_ok(const struct domain *d, >>> uint32_t emflags) >>> return true; >>> } >>> >>> -int arch_domain_create(struct domain *d, unsigned int domcr_flags, >>> - struct xen_arch_domainconfig *config) >>> +int arch_domain_create(struct domain *d, >>> + struct xen_domctl_createdomain *config) >> Is there any reason for this to not be const? There's no write now >> afaics, and I can't imagine you wanting to add one later on. > >I originally planned to make them const, but the ARM side passes data >back to the toolstack, and the prototype is (rightfully) common.
Oh, I see - certainly a little odd, but that's the way it is then. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
