Manish, On 12/03/18 12:42, mja...@caviumnetworks.com wrote: > From: Manish Jaggi <manish.ja...@cavium.com> > > This patchset is a Xen port of Marc's patchset. > arm64: KVM: Mediate access to GICv3 sysregs at EL2 [1] > > The current RFC patchset is a subset of [1], as it handleing only Group1 traps > as a PoC. Most of the trap code is added in vsysreg.c. Trap handler function > is kept > independent of the usual guest trap handling code. > Looking for feedback on this approach. Why Group-1 only? AFAIK, Group-0 is affected as well, and results in a DoS on the secure side. Only handling Group-1 makes it hard to compare to the reference implementation (which handles booth groups), and will introduce pointless churn once you start adding Group-0 handling.
As it stands, this series is a bit pointless. Please consider posting a complete fix. Thanks, M. -- Jazz is not dead. It just smells funny... _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel