Hi Andre,
On 05/03/18 16:04, Andre Przywara wrote:
When a VCPU moves to another CPU, we need to adjust the target affinity
of any hardware mapped vIRQs, to observe our "physical-follows-virtual"
policy.
Implement arch_move_irqs() to adjust the physical affinity of all hardware
mapped vIRQs targetting this VCPU.
Signed-off-by: Andre Przywara <andre.przyw...@linaro.org>
---
Changelog RFC ... v1:
- actually implement arch_move_irqs() (instead of just stubbing it)
xen/arch/arm/vgic/vgic.c | 42 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 42 insertions(+)
diff --git a/xen/arch/arm/vgic/vgic.c b/xen/arch/arm/vgic/vgic.c
index e1952c872d..5e767927c0 100644
--- a/xen/arch/arm/vgic/vgic.c
+++ b/xen/arch/arm/vgic/vgic.c
@@ -790,6 +790,48 @@ void gic_dump_vgic_info(struct vcpu *v)
spin_unlock_irqrestore(&v->arch.vgic.ap_list_lock, flags);
}
+/**
+ * arch_move_irqs() - migrate the physical affinity of hardware mapped vIRQs
+ * @v: the vCPU, already assigned to the new pCPU
+ *
+ * arch_move_irqs() updates the physical affinity of all virtual IRQs
+ * targetting this given vCPU. This only affects hardware mapped IRQs. The
+ * new pCPU to target is already set in v->processor.
+ * This is called by the core code after a vCPU has been migrated to a new
+ * physical CPU.
+ */
+void arch_move_irqs(struct vcpu *v)
+{
+ struct domain *d = v->domain;
+ unsigned int i;
+
+ /* We only target SPIs with this function */
+ for ( i = 0; i < d->arch.vgic.nr_spis; i++ )
+ {
+ struct vgic_irq *irq = vgic_get_irq(d, NULL, i + VGIC_NR_PRIVATE_IRQS);
+ unsigned long flags;
+ irq_desc_t *desc;
+
+ if ( !irq )
+ continue;
+
+ spin_lock_irqsave(&irq->irq_lock, flags);
+
+ /* only vIRQs that are not on a vCPU yet , but targetting this vCPU */
+ if ( irq->hw && !irq->vcpu && irq->target_vcpu == v)
+ desc = irq_to_desc(irq->hwintid);
+ else
+ desc = NULL;
+
+ spin_unlock_irqrestore(&irq->irq_lock, flags);
+
+ if ( desc )
+ vgic_sync_hardware_irq(d, desc, irq);
You want to look at my comment about using vgic_sync_hardware_irq for
routing on patch #43.
+
+ vgic_put_irq(d, irq);
+ }
+}
+
struct irq_desc *vgic_get_hw_irq_desc(struct domain *d, struct vcpu *v,
unsigned int virq)
{
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
