On Fri, Feb 23, 2018 at 09:03:26PM +0100, Marek Marczykowski-Górecki wrote: > On Fri, Feb 23, 2018 at 06:47:57PM +0000, Wei Liu wrote: > > On Fri, Feb 09, 2018 at 12:14:03AM +0100, Marek Marczykowski-Górecki wrote: > > > When fd=-1, no savefile will be written, but the domain will still be > > > suspended (but not destroyed). The main reason for this functionality is > > > to suspend the host while some domains are running, potentially holding > > > PCI devices. This will give a chance to a driver in such a domain to > > > properly suspend device. > > > > > > It would be better to have separate function for this, but in fact it > > > should be named libxl_domain_suspend, then the current one renamed to > > > libxl_domain_save. Since that would break API compatibility, keep it in > > > the same function. > > > > > > Signed-off-by: Marek Marczykowski-Górecki > > > <marma...@invisiblethingslab.com> > > > Signed-off-by: Marcus of Wetware Labs <mar...@wetwa.re> > > > > The basic idea seems sensible. > > > > Please add a comment to libxl.h to specify the new semantics. > > Hmm, while I'm looking at it, maybe better idea would be to use flags > for that? I'd call it LIBXL_SUSPEND_SUSPEND, but it looks stupid, any > better idea?
I don't have any better idea I'm afraid... Wei. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
