On 09/03/2018, 11:07, "Jan Beulich" <jbeul...@suse.com> wrote:
    >>> On 08.03.18 at 18:37, <lars.ku...@citrix.com> wrote:
    > --- a/SUPPORT.md
    > +++ b/SUPPORT.md
    > @@ -620,6 +620,7 @@ Note that other devices are available but not 
security supported.
    >  
    >  ### x86/Emulated platform devices (QEMU):
    >  
    > +    Status, PCI host bridge: Supported
    >      Status, piix3: Supported
    
    That's way too generic imo: Any chipset will have a host bridge, so
    its support is already included in the statement on which chipset
    emulation(s) we support. By adding what you add, you could again
    raise the expectation that any host bridge implementation in qemu
    is supported.

I thought this may be an issue. I would be quite happy to change it, but would 
need to know how to phrase it.
Suggestions?
    
    >  ### x86/Emulated network (QEMU):
    > @@ -633,10 +634,18 @@ Note that other devices are available but not 
security supported.
    >      Status, piix3 ide: Supported
    >      Status, ahci: Supported
    >  
    > +### x86/Emulated Storage Image Formats (QEMU):
    > +
    > +    Status, raw: Supported
    > +    Status, qcow: Supported
    > +    Status, qcow2: Supported
    > +    Status, vhd: Supported
    > +    
    >  ### x86/Emulated graphics (QEMU):
    >  
    >      Status, cirrus-vga: Supported
    > -    Status, stgvga: Supported
    > +    Status, stdvga: Supported
    > +    Status, xenfb: Supported
    
    Just like xen_disk (correctly) isn't listed in the "x86/Emulated storage
    (QEMU)" section, xenfb doesn't belong here imo. It's not an emulated
    device, and is already enumerated in "PV Framebuffer (backend)"
    (just not with the term "xenfb").

So, what I read from this, the existing line 

### PV Framebuffer (backend)
    Status, QEMU: Supported

covers the back-end.
    
    > @@ -650,7 +659,9 @@ Note that other devices are available but not 
security supported.
    >      Status, usbtablet: Supported
    >      Status, ps/2 keyboard: Supported
    >      Status, ps/2 mouse: Supported
    > -
    > +    Status, xenfb keyboard: Supported
    > +    Status, xenfb mouse: Supported
    
    Similarly for these ones and "PV keyboard (backend)". Perhaps a
    "PV mouse (backend)" section should be added.
 
So to clarify, 

### PV keyboard (backend)
    Status, QEMU: Supported
### PV mouse (backend)
    Status, QEMU: Supported

would cover this in your view?

Does this cover all the bases, or did I miss anything? 
In other words, are there any frontend bits for xenfb (framebuffer, keyboard, 
mouse) that would need to be recorded somewhere

Regards
Lars

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Reply via email to