On Tue, 27 Feb 2018, julien.gr...@arm.com wrote:
> From: Stewart Hildebrand <stewart.hildebr...@dornerworks.com>
>
> Since commit "xen/arm: domain_build: Rework the way to allocate the
> event channel interrupt", it is not possible for an irq to be both below 16
> and greater/equal than 32.
>
> Also fix the reference to linux documentation while we're at it.
>
> Signed-off-by: Stewart Hildebrand <stewart.hildebr...@dornerworks.com>
> Signed-off-by: Julien Grall <julien.gr...@arm.com>
> [Slightly rework the commit message]
Acked-by: Stefano Stabellini <sstabell...@kernel.org>
> ---
> xen/arch/arm/domain_build.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index ed1a393bb5..28ee876b92 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -503,9 +503,10 @@ static void set_interrupt_ppi(gic_interrupt_t interrupt,
> unsigned int irq,
> {
> __be32 *cells = interrupt;
>
> - BUG_ON(irq < 16 && irq >= 32);
> + BUG_ON(irq < 16);
> + BUG_ON(irq >= 32);
>
> - /* See linux Documentation/devictree/bindings/arm/gic.txt */
> + /* See linux
> Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt */
> dt_set_cell(&cells, 1, 1); /* is a PPI */
> dt_set_cell(&cells, 1, irq - 16); /* PPIs start at 16 */
> dt_set_cell(&cells, 1, (cpumask << 8) | level);
> --
> 2.11.0
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
