On 02/16/2018 02:18 PM, Roger Pau Monne wrote:
> Previous usage is not correct and would prevent certain updates from
> being notified to the monitor client.
>
> For example if (value ^ old) == (PGE | PSE) and mask == PGE this
> update would not be notified.
>
> Signed-off-by: Roger Pau Monné <roger....@citrix.com>
> ---
> Cc: Razvan Cojocaru <rcojoc...@bitdefender.com>
> Cc: Tamas K Lengyel <ta...@tklengyel.com>
> Cc: Jan Beulich <jbeul...@suse.com>
> Cc: Andrew Cooper <andrew.coop...@citrix.com>
> ---
> xen/arch/x86/hvm/monitor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/x86/hvm/monitor.c b/xen/arch/x86/hvm/monitor.c
> index 131b85209f..04665c5f6c 100644
> --- a/xen/arch/x86/hvm/monitor.c
> +++ b/xen/arch/x86/hvm/monitor.c
> @@ -39,7 +39,7 @@ bool hvm_monitor_cr(unsigned int index, unsigned long
> value, unsigned long old)
> if ( (ad->monitor.write_ctrlreg_enabled & ctrlreg_bitmask) &&
> (!(ad->monitor.write_ctrlreg_onchangeonly & ctrlreg_bitmask) ||
> value != old) &&
> - (!((value ^ old) & ad->monitor.write_ctrlreg_mask[index])) )
> + ((value ^ old) & ~ad->monitor.write_ctrlreg_mask[index]) )
> {
> bool sync = ad->monitor.write_ctrlreg_sync & ctrlreg_bitmask;
Acked-by: Razvan Cojocaru <rcojoc...@bitdefender.com>
Thanks,
Razvan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
