On Mon, Feb 05, 2018 at 03:37:06PM +0000, Andrew Cooper wrote: > Indenting is off, but that can be fixed on commit.
Oopsy, sorry about that. > As some extra cleanup, what about folding this diff in? It avoids > repeatedly hitting the cleanbits, and is clearer to follow IMO. > > ~Andrew > It's functionally the same. It's a trade off of whether you want to write/read to the VMCB twice (assuming both are changing) or go through more if statements every time. The clean bits are just a field in the VMCB so. Some of the VMCB fields are only read on change with my version but to be honest, I don't think it matters either way. I like the locality of mine better, but I'm perfectly fine with either. -- Brian Woods _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
