On Wed, Jan 24, 2018 at 03:49:16PM +0000, Andrew Cooper wrote: > The use of __LINE__ in a printk() is problematic for livepatching, as it > causes unnecessary binary differences. > > Furthermore, diagnostic information around calls is inconsistent and > occasionally unhelpful. (e.g. diagnosing logs from the field which might be > release builds, or likely without exact source code). > > Take the opportunity to improve things. Shorten the name to > domain_crash_sync() and require the user to pass a print message in. > > Internally, the current vcpu and calling function are identified, and the > message is emitted as a non-debug guest error. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com>
I think I saw this at some point, from Ross like a year ago? Anyhow: Reviewed-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
