> On 17 Jan 2018, at 10:31, Julien Grall <julien.gr...@linaro.org> wrote: > > Hi Stefano, > > On 16/01/18 23:55, Stefano Stabellini wrote: >> On Tue, 16 Jan 2018, Julien Grall wrote: >>> Once Xen knows what features/workarounds present on the platform, it >>> might be necessary to configure each online CPU. >>> >>> Introduce a new callback "enable" that will be called on each online CPU to >>> configure the "capability". >>> >>> The code is based on Linux v4.14 (where cpufeature.c comes from), the >>> explanation of why using stop_machine_run is kept as we have similar >>> problem in the future. >>> >>> Lastly introduce enable_errata_workaround that will be called once CPUs >>> have booted and before the hardware domain is created. >>> >>> This is part of XSA-254. >>> >>> Signed-of-by: Julien Grall <julien.gr...@linaro.org> >> If you took the code from Linux, you need to add the original >> Signed-off-by from the Linux commit. Aside from that: > > There are multiple commits touching this function. So I followed what we did > in similar situation. By that I mean, mentioning the code was taken from > Linux and not gathered the signed-off-by. > > If you really want, I can gather all the signed-off-by of the commit touching > this function.
If there are a lot of then, you may want to consider adding a README.source file instead. There are a few examples in tree and they are also mentioned in CONTRIBUTING files Lars
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel