On 01/11/2018 04:48 PM, Andrew Cooper wrote: > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > --- > CC: George Dunlap <george.dun...@eu.citrix.com> > CC: Dario Faggioli <dfaggi...@suse.com> > > Notices by chance while inspecting the disassembly delta for "x86/bitops: > Introduce variable/constant pairs for __{set,clear,change}_bit()" > --- > xen/common/sched_credit2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c > index 18f39ca..ee9768e 100644 > --- a/xen/common/sched_credit2.c > +++ b/xen/common/sched_credit2.c > @@ -2063,7 +2063,7 @@ csched2_vcpu_sleep(const struct scheduler *ops, struct > vcpu *vc) > update_load(ops, svc->rqd, svc, -1, NOW()); > runq_remove(svc); > } > - else if ( svc->flags & CSFLAG_delayed_runq_add ) > + else > __clear_bit(__CSFLAG_delayed_runq_add, &svc->flags);
There was a reason for this at some point, I'm sure. Did this used to be the atomic version (without the __) originally? -George _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel