>>> On 09.01.18 at 17:09, <roger....@citrix.com> wrote: > On Mon, Jan 08, 2018 at 07:06:14AM -0700, Jan Beulich wrote: >> >>> On 04.01.18 at 14:06, <wei.l...@citrix.com> wrote: >> > From: Roger Pau Monne <roger....@citrix.com> >> > --- a/xen/arch/x86/pv/dom0_build.c >> > +++ b/xen/arch/x86/pv/dom0_build.c >> > @@ -31,9 +31,8 @@ >> > #define L3_PROT (BASE_PROT|_PAGE_DIRTY) >> > #define L4_PROT (BASE_PROT|_PAGE_DIRTY) >> > >> > -static __init void dom0_update_physmap(struct domain *d, unsigned long >> > pfn, >> > - unsigned long mfn, >> > - unsigned long vphysmap_s) >> > +__init void dom0_update_physmap(struct domain *d, unsigned long pfn, >> >> Please don't re-order type and annotation. > > I'm not re-ordering anything here, just removing "static".
Oops, I'm sorry. Things being mis-ordered simply becomes more obvious with the "static gone". > Do you mean that you prefer "void __init ..."? Yes. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
