>>> On 12.12.17 at 17:32, <george.dun...@citrix.com> wrote: >> @@ -82,7 +153,7 @@ struct page_info >> unsigned long type:5; /* What kind of shadow is this? */ >> unsigned long pinned:1; /* Is the shadow pinned? */ >> unsigned long head:1; /* Is this the first page of the >> shadow? */ >> -#define PAGE_SH_REFCOUNT_WIDTH 25 >> +#define PAGE_SH_REFCOUNT_WIDTH (PGT_count_width - 7) >> unsigned long count:PAGE_SH_REFCOUNT_WIDTH; /* Reference count >> */ >> } sh;
It is this use of PGT_count_width ... > What's the point of moving this code? And are there any important changes? ... which requires the move. I thought that would be clear enough. > It would be a lot easier to review if you separated code motion from > code changes; but if you don't want to do that, you need to make it > clear what you're doing in your changelog. I've added "Note that the first and last hunks of the xen/include/asm-x86/mm.h change are merely code motion." to the description; I don't think separating out that change would make review any easier (you either trust the code-motion-only statement, or you want to compare both blocks, regardless of whether this was a separate patch). Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
