>>> On 06.12.17 at 21:06, <andrew.coop...@citrix.com> wrote: > Since c/s 49de10f3c1718 "x86/hvm: Don't raise #GP behind the emulators back > for MSR accesses", returnning X86EMUL_EXCEPTION has pushed the exception > generation to the top of the call tree. > > Using hvm_inject_hw_exception() and returning X86EMUL_EXCEPTION causes a > double #GP injection, which combines to #DF. > > While fixing this up, rename uncanonical_address to the more common gp_fault,
It would seem even better to drop that label altogether, not that this is being followed by a single "return". > and drop the HVM_DBG_LOG() line which is redundant given the two adjacent > lines. Two adjacent lines? Not in source code, and in terms of resulting log lines I can see coming from the start of long_mode_do_msr_write(), but I can#t seem to be able to spot a second (presumably later) one. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
