On Tue, Nov 28, 2017 at 05:55:15PM +0100, Marc-André Lureau wrote: [...] > Hi > > On Sat, Nov 25, 2017 at 4:16 PM, Eduardo Habkost <ehabk...@redhat.com> wrote: > > The existing has_dynamic_sysbus flag makes the machine accept > > every user-creatable sysbus device type on the command-line. > > Replace it with a list of allowed device types, so machines can > > easily accept some sysbus devices while rejecting others. > > > > To keep exactly the same behavior as before, the existing > > has_dynamic_sysbus=true assignments are replaced with a > > TYPE_SYS_BUS_DEVICE entry on the allowed list. Other patches > > will replace the TYPE_SYS_BUS_DEVICE entries with more specific > > lists of devices. > > > > Cc: Peter Maydell <peter.mayd...@linaro.org> > > Cc: Marcel Apfelbaum <mar...@redhat.com> > > Cc: "Michael S. Tsirkin" <m...@redhat.com> > > Cc: Alexander Graf <ag...@suse.de> > > Cc: David Gibson <da...@gibson.dropbear.id.au> > > Cc: Stefano Stabellini <sstabell...@kernel.org> > > Cc: Anthony Perard <anthony.per...@citrix.com> > > Cc: qemu-...@nongnu.org > > Cc: qemu-...@nongnu.org > > Cc: xen-devel@lists.xenproject.org > > Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> > > Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com>
Thanks! [...] > > - mc->has_dynamic_sysbus = true; > > + /*TODO: allow only sysbus devices that really work with this machine */ > > cosmetic: why do you not leave a space between * and TODO ? (you did > that repeatedly) Good question. :) For reasons I can't explain, I thought "/*TODO:" was more common than "/* TODO:", but I was mistaken. I will change this to "/* TODO:" when committing the patches. -- Eduardo _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
