>>> On 08.03.17 at 16:33, <yu.c.zh...@linux.intel.com> wrote:
> --- a/xen/arch/x86/mm/p2m.c
> +++ b/xen/arch/x86/mm/p2m.c
> @@ -954,6 +954,26 @@ int p2m_change_type_one(struct domain *d, unsigned long
> gfn,
> p2m->default_access)
> : -EBUSY;
>
> + if ( !rc )
> + {
> + switch ( nt )
> + {
> + case p2m_ram_rw:
> + if ( ot == p2m_ioreq_server )
> + {
> + p2m->ioreq.entry_count--;
> + ASSERT(p2m->ioreq.entry_count >= 0);
> + }
> + break;
> + case p2m_ioreq_server:
> + if ( ot == p2m_ram_rw )
> + p2m->ioreq.entry_count++;
I don't think the conditional is needed here. If anything it should be
an ASSERT() imo, as other transitions to p2m_ioreq_server should
not be allowed.
But there's a wider understanding issue I'm having here: What is
an "entry" here? Commonly I would assume this to refer to an
individual (4k) page, but it looks like you really mean table entry,
i.e. possibly representing a 2M or 1G page.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
