Hi Stefano,

On 16/02/17 01:49, Stefano Stabellini wrote:
On Wed, 15 Feb 2017, Stefano Stabellini wrote:
On Fri, 3 Feb 2017, Julien Grall wrote:
The code to add a new bank is duplicated twice. Add a new helper that
checks if the maximum of bank has not reached and adds the bank.

Signed-off-by: Julien Grall <julien.gr...@arm.com>

Reviewed-by: Stefano Stabellini <sstabell...@kernel.org>


---
 xen/arch/arm/efi/efi-boot.h | 34 ++++++++++++++++++----------------
 1 file changed, 18 insertions(+), 16 deletions(-)

diff --git a/xen/arch/arm/efi/efi-boot.h b/xen/arch/arm/efi/efi-boot.h
index 045d6ce..757d9c6 100644
--- a/xen/arch/arm/efi/efi-boot.h
+++ b/xen/arch/arm/efi/efi-boot.h
@@ -124,15 +124,27 @@ static void __init 
*lookup_fdt_config_table(EFI_SYSTEM_TABLE *sys_table)
     return fdt;
 }

+static bool meminfo_add_bank(struct meminfo *mem, EFI_MEMORY_DESCRIPTOR *desc)

actually this function should be __init, right?

Yes it should, I will fix it in the next version.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Reply via email to