On Wed, Mar 01, 2017 at 04:16:32PM +0000, Paul Durrant wrote: > > -----Original Message----- > > From: Anthony PERARD [mailto:anthony.per...@citrix.com] > > Sent: 01 March 2017 16:14 > > To: Paul Durrant <paul.durr...@citrix.com> > > Cc: xen-de...@lists.xenproject.org; qemu-de...@nongnu.org; Stefano > > Stabellini <sstabell...@kernel.org>; Paolo Bonzini <pbonz...@redhat.com>; > > Richard Henderson <r...@twiddle.net>; Eduardo Habkost > > <ehabk...@redhat.com>; Michael S. Tsirkin <m...@redhat.com> > > Subject: Re: [PATCH 3/5] xen: create wrappers for all other uses of > > xc_hvm_XXX() functions > > > > On Thu, Feb 23, 2017 at 02:53:53PM +0000, Paul Durrant wrote: > > > This patch creates inline wrapper functions in xen_common.h for all open > > > coded calls to xc_hvm_XXX() functions outside of xen_common.h so that > > use > > > of xen_xc can be made implicit. This again is in preparation for the move > > > to using libxendevicemodel. > > > > > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> > > > --- > > > diff --git a/include/hw/xen/xen_common.h > > b/include/hw/xen/xen_common.h > > > index 1e08b98..31cf25f 100644 > > > --- a/include/hw/xen/xen_common.h > > > +++ b/include/hw/xen/xen_common.h > > > @@ -26,6 +26,50 @@ extern xc_interface *xen_xc; > > > * We don't support Xen prior to 4.2.0. > > > */ > > > > > > +static inline int xen_set_mem_type(domid_t domid, hvmmem_type_t > > type, > > > + uint64_t first_pfn, uint32_t nr) > > > +{ > > > > I don't know if it matters from where the functions are called, but > > here, xc_hvm_set_mem_type takes a "uint64_t nr" (and not uint32_t). > > Yes, the old APIs were wrong and discarded the upper 32 bits, so limiting > here is correct. Moving to the new API fixes the issue.
OK, thanks. In that case: Reviewed-by: Anthony PERARD <anthony.per...@citrix.com> -- Anthony PERARD _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
