>>> On 20.02.17 at 12:00, <andrew.coop...@citrix.com> wrote:
> Leaf 0xb is reserved by AMD, and uniformly hidden from guests by the toolstack
> logic and hypervisor PV logic.
>
> The previous dynamic logic filled in the x2APIC ID for all HVM guests. This
> is modified to respect the entire leaf being reserved by AMD, but is altered
> to include PV Intel guests, so they get more sensible values in their emulated
> and faulted view of CPUID.
Don't we expose x2APIC to HVM guests even on AMD systems? In
which case we surely will want to also expose the x2APIC ID.
> @@ -959,6 +950,14 @@ void guest_cpuid(const struct vcpu *v, uint32_t leaf,
> }
> break;
>
> + case 0xb:
> + if ( p->x86_vendor == X86_VENDOR_INTEL )
> + {
> + /* Fix the x2APIC identifier. */
> + res->d = v->vcpu_id * 2;
> + }
> + break;
Irrespective of the comment above, wouldn't the if() here better
look at the x2APIC feature flag of the domain?
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
