On 21/02/17 13:46, Boris Ostrovsky wrote: >> diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c >> index 894c457..b864535 100644 >> --- a/xen/arch/x86/hvm/svm/svm.c >> +++ b/xen/arch/x86/hvm/svm/svm.c >> @@ -1744,7 +1744,6 @@ static int svm_msr_read_intercept(unsigned int msr, >> uint64_t *msr_content) >> return X86EMUL_OKAY; >> >> gpf: >> - hvm_inject_hw_exception(TRAP_gp_fault, 0); >> return X86EMUL_EXCEPTION; >> } >> >> @@ -1897,7 +1896,6 @@ static int svm_msr_write_intercept(unsigned int msr, >> uint64_t msr_content) >> return result; >> >> gpf: >> - hvm_inject_hw_exception(TRAP_gp_fault, 0); >> return X86EMUL_EXCEPTION; >> } > The label can be dropped with a direct return instead of a 'goto'. > Either way
I will do cleanup like that into the start of the MSR levelling work, which will be bringing other changes to the functions as well. ~Andrew
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel