>>> On 16.02.17 at 18:13, <andrew.coop...@citrix.com> wrote: > They depend soley on paging mode, so don't need to be repeated per domain, and > can live in .rodata. While making this change, drop the redundant log_dirty > from the function pointer names. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com>
Reviewed-by: Jan Beulich <jbeul...@suse.com> but ... > @@ -624,22 +624,15 @@ void paging_log_dirty_range(struct domain *d, > flush_tlb_mask(d->domain_dirty_cpumask); > } > > -/* Note that this function takes three function pointers. Callers must supply > - * these functions for log dirty code to call. This function usually is > - * invoked when paging is enabled. Check shadow_enable() and hap_enable() for > - * reference. > +/* Callers must supply log_dirty_ops for the log dirty code to call. This > + * function usually is invoked when paging is enabled. Check shadow_enable() > + * and hap_enable() for reference. ... would you mind fixing the style of this comment as you're touching it anyway? Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
