> From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Tuesday, January 31, 2017 6:56 PM > > >>> On 31.01.17 at 11:39, <andrew.coop...@citrix.com> wrote: > > On 31/01/17 10:19, Jan Beulich wrote: > >>>>> On 30.01.17 at 17:54, <andrew.coop...@citrix.com> wrote: > >>> This results in rather more readable code. No functional change. > >>> > >>> All fields currently specified are included, but commented out as no > >>> support > >>> for their use is present. > >> I'd rather not see them be commented out: Why should the first user > >> of them have to touch the structure declaration another time? > > > > I purposefully don't want someone to think they can use .eff_user_exec > > before doing the work to enable the feature (which amongst other things > > will involve shuffling the position of bits in an ept_entry_t as the > > hardware user exec bit is currently where Xen's .recalc bit currently > > lives). > > For this bit I understand the reasoning. I don't think the same applies > to bits 9..12 though. >
I'm with Jan on this front. Could you resend the patch with comment only applying to above bit? Thanks Kevin _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
