On Mon, Jan 30, 2017 at 03:33:18PM +0100, Fatih Acar wrote: > libxl_domain_build_info_dispose is not resetting the type field to > LIBXL_DOMAIN_TYPE_INVALID. > Instead, it is memseting the struct to 0 thus when > libxl_domain_build_info_init_type is called > after a dispose on the same struct, an assertion is triggered because type != > LIBXL_DOMAIN_TYPE_INVALID. > Calling libxl_domain_build_info_init makes sure the type field is correctly > initialized. > > Signed-off-by: Fatih Acar <fatih.a...@gandi.net> > Signed-off-by: Nikita Kozlov <nikita.koz...@gandi.net> > Signed-off-by: Vincent Legout <vincent.leg...@gandi.net> > Signed-off-by: Baptiste Daroussin <baptiste.darous...@gandi.net>
Acked-by: Wei Liu <wei.l...@citrix.com> > --- > tools/libxl/xl_cmdimpl.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c > index 7e8a8ae..196b8a6 100644 > --- a/tools/libxl/xl_cmdimpl.c > +++ b/tools/libxl/xl_cmdimpl.c > @@ -2535,6 +2535,7 @@ static void reload_domain_config(uint32_t domid, > if (t_len > 0) { > LOG("\"xl\" configuration found, using it\n"); > libxl_domain_config_dispose(d_config); > + libxl_domain_config_init(d_config); > parse_config_data("<updated>", (const char *)t_data, > t_len, d_config); > free(t_data); > -- > bapt is my cto > _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel