* Andy Lutomirski <l...@kernel.org> wrote:
> On Wed, Feb 1, 2017 at 1:15 AM, Ingo Molnar <mi...@kernel.org> wrote:
> >
> > * Thomas Garnier <thgar...@google.com> wrote:
> >
> >> This patch makes the GDT remapped pages read-only to prevent corruption.
> >> This change is done only on 64 bit.
> >
>
>
> >>
> >> - table_base = gdt->address;
> >> + table_base = (unsigned long)get_current_direct_gdt();
> >
> > Instead of spreading these type casts far and wide please introduce another
> > accessor the returns 'unsigned long':
> >
> > get_cpu_gdt_rw_vaddr()
> >
>
> That whole function is an abomination. How about replacing 'unsigned
> long table_base' with 'struct desc_struct *table'? If you're feeling
> really adventurous, *delete* that function and replace all of its
> users with something sane.
Yeah, even better!
Thanks,
Ingo
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
