On Thu, Jan 19, 2017 at 02:01:24PM +0800, Yi Sun wrote:
> This patch implements changes in xl/xc changes to support
> showing CBM of L2 CAT.
>
> The new level option is introduced to original CAT showing
> command in order to show CBM for specified level CAT.
> - 'xl psr-cat-show' is updated to show CBM of a domain
> according to input cache level.
>
> Examples:
> root@:~$ xl psr-cat-show -l2 1
> Socket ID : 0
> Default CBM : 0xff
> ID NAME CBM
> 1 ubuntu14 0x7f
>
> Signed-off-by: He Chen <he.c...@linux.intel.com>
> Signed-off-by: Yi Sun <yi.y....@linux.intel.com>
Acked-by: Wei Liu <wei.l...@citrix.com>
One minor nit.
[...]
> -static int psr_cat_print_socket(uint32_t domid, libxl_psr_cat_info *info)
> +static int psr_cat_print_socket(uint32_t domid, libxl_psr_cat_info *info,
> + unsigned int lvl)
> {
> int rc;
> uint32_t l3_cache_size;
>
> - rc = libxl_psr_cmt_get_l3_cache_size(ctx, info->id, &l3_cache_size);
> - if (rc) {
> - fprintf(stderr, "Failed to get l3 cache size for socket:%d\n",
> - info->id);
> - return -1;
> + printf("%-16s: %u\n", "Socket ID", info->id);
> +
> + /* So far, CMT only supports L3 cache. */
> + if (lvl == 3)
> + {
Please put '{' on previous line.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
