On Wed, 25 Jan 2017, Paul Durrant wrote: > > -----Original Message----- > > From: Stefano Stabellini [mailto:sstabell...@kernel.org] > > Sent: 24 January 2017 23:49 > > To: Paul Durrant <paul.durr...@citrix.com> > > Cc: qemu-de...@nongnu.org; xen-de...@lists.xenproject.org; Stefano > > Stabellini <sstabell...@kernel.org>; Anthony Perard > > <anthony.per...@citrix.com>; Michael S. Tsirkin <m...@redhat.com>; Paolo > > Bonzini <pbonz...@redhat.com>; Richard Henderson <r...@twiddle.net>; > > Eduardo Habkost <ehabk...@redhat.com>; o...@aepfle.de > > Subject: Re: [PATCH v2 2/3] xen-platform: add support for unplugging NVMe > > disks... > > > > On Tue, 24 Jan 2017, Paul Durrant wrote: > > > ...not just IDE and SCSI. > > > > > > This patch allows the Xen tool-stack to fully support of NVMe as an > > > emulated disk type. > > > > > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com> > > > > Please update docs/misc/hvm-emulated-unplug.markdown in the Xen > > repository first. It might be also worth clarifying that `1` actually > > means all disks, not just IDE disks. Then, please add a reference to > > that commit in the description of this patch. > > > > Patch posted to remove 'IDE' from the documentation for value '1'. Awaiting > ack.
Done. When you repost this patch, could you also add to the description a reference to the commit that enables NVMe in QEMU with Xen? I guess it is a libxl commit? > > > --- > > > Cc: Stefano Stabellini <sstabell...@kernel.org> > > > Cc: Anthony Perard <anthony.per...@citrix.com> > > > Cc: "Michael S. Tsirkin" <m...@redhat.com> > > > Cc: Paolo Bonzini <pbonz...@redhat.com> > > > Cc: Richard Henderson <r...@twiddle.net> > > > Cc: Eduardo Habkost <ehabk...@redhat.com> > > > --- > > > hw/i386/xen/xen_platform.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/hw/i386/xen/xen_platform.c b/hw/i386/xen/xen_platform.c > > > index f50915f..7d41ebb 100644 > > > --- a/hw/i386/xen/xen_platform.c > > > +++ b/hw/i386/xen/xen_platform.c > > > @@ -120,6 +120,7 @@ static void unplug_disks(PCIBus *b, PCIDevice *d, > > void *o) > > > break; > > > > > > case PCI_CLASS_STORAGE_SCSI: > > > + case PCI_CLASS_STORAGE_EXPRESS: > > > object_unparent(OBJECT(d)); > > > break; > > > > > > -- > > > 2.1.4 > > > > _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
