> -----Original Message----- > From: Xen-devel [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of Jan > Beulich > Sent: 20 January 2017 16:38 > To: Paul Durrant <paul.durr...@citrix.com> > Cc: Wei Liu <wei.l...@citrix.com>; Andrew Cooper > <andrew.coop...@citrix.com>; Jennifer Herbert > <jennifer.herb...@citrix.com>; Ian Jackson <ian.jack...@citrix.com>; xen- > de...@lists.xenproject.org; Daniel De Graaf <dgde...@tycho.nsa.gov> > Subject: Re: [Xen-devel] [PATCH v4 1/8] public / x86: Introduce > __HYPERCALL_dm_op... > > >>> On 20.01.17 at 17:20, <paul.durr...@citrix.com> wrote: > >> From: Jan Beulich [mailto:jbeul...@suse.com] > >> Sent: 20 January 2017 16:18 > >> >>> On 17.01.17 at 18:29, <paul.durr...@citrix.com> wrote: > >> > +#ifndef __XEN_PUBLIC_HVM_DM_OP_H__ > >> > +#define __XEN_PUBLIC_HVM_DM_OP_H__ > >> > + > >> > +#if defined(__XEN__) || defined(__XEN_TOOLS__) > >> > + > >> > +#include "../xen.h" > >> > + > >> > +#define XEN_DMOP_invalid 0 > >> > >> Do we actually need this, btw? > >> > > > > Not really, I just prefer to have 0 be an invalid sub-op and #defining it > > this way makes that obvious. > > Well, as soon as there are subops 1, 2, 3, ... it'll be obvious too. >
Ok. I'll take it out then. Paul > Jan > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > https://lists.xen.org/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
