On 12/08/16 16:33, Anthony PERARD wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Anthony PERARD <anthony.per...@citrix.com> > --- > OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf > b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf > index ecd462b..2e0ed48 100644 > --- a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf > +++ b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf > @@ -36,4 +36,5 @@ > [LibraryClasses] > DebugLib > IoLib > + PciLib > TimerLib >
Please also #include <Library/PciLib.h> in "ResetSystemLib.c", for consistency with the now-modified INF file. (The lack of the #include directive is currently masked by the fact that "OvmfPlatforms.h" includes "PciLib.h" too -- it needs PCI_LIB_ADDRESS().) Also... not sure why, but we include "OvmfPlatforms.h" twice in "ResetSystemLib.c". Can you please kill the second #include? Can be in the same patch. (Hm, it looks like the duplicate #include is my fault, an oversight from commit 1466b76f9385.) Thanks! Laszlo _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
