On 03/01/17 14:12, Jan Beulich wrote: > >>> --- a/xen/arch/x86/x86_emulate/x86_emulate.h >>> +++ b/xen/arch/x86/x86_emulate/x86_emulate.h >>> @@ -583,41 +583,9 @@ x86_emulate( >>> const struct x86_emulate_ops *ops); >>> >>> #ifndef NDEBUG >>> -/* >>> - * In debug builds, wrap x86_emulate() with some assertions about its >>> expected >>> - * behaviour. >>> - */ >> I'd leave this comment here as well. > Hmm, in that case I'd drop it at the definition site. I don't think we > need to have the comment in both places. What do you think?
If you insist on only having it in one place, I'd err on having it in the header file. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
