On Tue, Dec 13, 2016 at 07:53:02AM -0700, Jan Beulich wrote: > >>> On 13.12.16 at 15:17, <rcojoc...@bitdefender.com> wrote: > > While re-basing the patch on staging, I've got this (unrelated) error > > while doing 'make dist': > > > > make[9]: Entering directory `~/work/xen.git/tools/firmware/rombios/32bit' > > gcc -m32 -march=i686 -DBUILD_ID -g -fno-strict-aliasing -std=gnu99 > > -Wall -Wstrict-prototypes -Wdeclaration-after-statement > > -Wno-unused-but-set-variable -Wno-unused-local-typedefs -O0 -g3 > > -fno-omit-frame-pointer > > -D__XEN_INTERFACE_VERSION__=__XEN_LATEST_INTERFACE_VERSION__ -MMD -MF > > .util.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE > > -mno-tls-direct-seg-refs -Werror -fno-stack-protector -fno-exceptions > > -fno-builtin -msoft-float > > -I/home/red/work/xen.git/tools/firmware/rombios/32bit/../../../../tools/inclu > > de > > -I.. -I../../../libacpi -c -o util.o util.c > > util.c: In function ‘get_s3_waking_vector’: > > util.c:453:23: error: dereferencing pointer to incomplete type > > if (!fadt || (fadt->header.signature != ACPI_2_0_FADT_SIGNATURE)) > > ^ > > util.c:453:45: error: ‘ACPI_2_0_FADT_SIGNATURE’ undeclared (first use in > > this function) > > if (!fadt || (fadt->header.signature != ACPI_2_0_FADT_SIGNATURE)) > > ^ > > util.c:453:45: note: each undeclared identifier is reported only once > > for each function it appears in > > util.c:456:45: error: dereferencing pointer to incomplete type > > facs = (struct acpi_20_facs *)(long)fadt->x_firmware_ctrl; > > ^ > > make[9]: *** [util.o] Error 1 > > Roger, this indicates you didn't build everything that can be built > with the libacpi changes which went in today. Please indicate > whether you think a fix is easy to put together, or whether to > revert.
Hello, Sorry, rombios doesn't build on FreeBSD, neither I was expecting libacpi headers to leak into it (TBH it looks like a layering violantion). Just send a patch to fix the build. Roger. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
