>>> On 08.12.16 at 23:57, <tamas.leng...@zentific.com> wrote: > --- a/xen/arch/x86/mm/Makefile > +++ b/xen/arch/x86/mm/Makefile > @@ -9,6 +9,7 @@ obj-y += guest_walk_3.o > obj-y += guest_walk_4.o > obj-y += mem_paging.o > obj-y += mem_sharing.o > +obj-y += mem_access.o
Please honor prior (mostly?) alphabetical ordering. > --- a/xen/common/mem_access.c > +++ b/xen/common/mem_access.c > @@ -24,8 +24,9 @@ > #include <xen/guest_access.h> > #include <xen/hypercall.h> > #include <xen/vm_event.h> > +#include <xen/mem_access.h> > #include <public/memory.h> > -#include <asm/p2m.h> > +#include <asm/mem_access.h> > #include <xsm/xsm.h> Normally asm/ includes xen/ of the same name or the other way around, depending on how they relate to one another; you shouldn't ever need both includes, and I'd be surprised if the two headers really are (even conceptionally) completely independent of each other. Otherwise this all looks like pure code motion (except for the adjustments described), but it would be nice if you could clarify that's indeed (intended to be) the case. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
