In function xenstored_local_init(), the value of return variable err should be negative on errors. But the value of err keeps 0 even if the call to get_zeroed_page() returns a NULL pointer. This patch assigns "-ENOMEM" to err on the error branch.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188721 Signed-off-by: Pan Bian <bianpan2...@163.com> --- drivers/xen/xenbus/xenbus_probe.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/xen/xenbus/xenbus_probe.c b/drivers/xen/xenbus/xenbus_probe.c index 33a31cf..f87d047 100644 --- a/drivers/xen/xenbus/xenbus_probe.c +++ b/drivers/xen/xenbus/xenbus_probe.c @@ -708,8 +708,10 @@ static int __init xenstored_local_init(void) /* Allocate Xenstore page */ page = get_zeroed_page(GFP_KERNEL); - if (!page) + if (!page) { + err = -ENOMEM; goto out_err; + } xen_store_gfn = xen_start_info->store_mfn = virt_to_gfn((void *)page); -- 1.9.1 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
