> -----Original Message-----
[snip]
> >> > +static int dm_op_set_pci_link_route(struct domain *d, uint8_t link,
> >> > + uint8_t isa_irq)
> >> > +{
> >> > + if ( link > 3 || isa_irq > 15 )
> >> > + return -EINVAL;
> >> > +
> >> > + hvm_set_pci_link_route(d, link, isa_irq);
> >> > +
> >> > + return 0;
> >> > +}
> >>
> >> In the hvmctl series I did specifically avoid to create this trivial a
> >> wrapper for a function with no other callers. Simply move the
> >> argument range checks there.
> >
> > Ok, I'll inline in the switch if you prefer that style.
>
> I didn't mean to inline the above in the case statement, but to
> move the argument checking to hvm_set_pci_link_route() (and
> call it directly from the case statement).
>
Oh, I see. Yes, that would be much better.
Paul
> Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
