>>> On 22.11.16 at 16:57, <boris.ostrov...@oracle.com> wrote: > On 11/22/2016 10:25 AM, Jan Beulich wrote: >>>>> On 21.11.16 at 22:00, <boris.ostrov...@oracle.com> wrote: >>> PVH guests do not have IOAPIC which typically generates an SCI. For >>> those guests SCI will be provided as a virtual interrupt. >>> >>> We also move VIRQ_MCA definition out of xen-mca.h to >>> keep all x86-specific VIRQ_ARCH_* in one place. >> >> While I appreciate the idea, you can't: xen-mca.h doesn't include >> xen.h, and hence parties consuming xen-mca.h alone may then see >> their build broken. > > Right. > > Any reason we can't include "xen.h" here?
I'm personally of the opinion that we shouldn't force unnecessary header dependencies onto every consumer. But maybe everone else disagrees ... Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel