On 22/11/16 14:20, Jan Beulich wrote:
> Suggested-by: George Dunlap <george.dun...@citrix.com>
> Signed-off-by: Jan Beulich <jbeul...@suse.com>
Possibly worth nothing in the commit message that the current
implementation of this hook when present never fails with MSR_EFER?
Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com>
>
> --- a/xen/arch/x86/x86_emulate/x86_emulate.c
> +++ b/xen/arch/x86/x86_emulate/x86_emulate.c
> @@ -1296,10 +1296,10 @@ in_longmode(
> {
> uint64_t efer;
>
> - if (ops->read_msr == NULL)
> + if ( !ops->read_msr ||
> + unlikely(ops->read_msr(MSR_EFER, &efer, ctxt) != X86EMUL_OKAY) )
> return -1;
>
> - ops->read_msr(MSR_EFER, &efer, ctxt);
> return !!(efer & EFER_LMA);
> }
>
>
>
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
