On 11/17/16 11:18, Konrad Rzeszutek Wilk wrote:
On Thu, Nov 17, 2016 at 10:05:58AM -0600, Suravee Suthikulpanit wrote:
Konrad,
Thanks for the review comments. Got one quick question below.
On 10/12/16 15:02, Konrad Rzeszutek Wilk wrote:
+int svm_avic_init_vmcb(struct vcpu *v)
+{
+ paddr_t ma;
+ u32 apic_id_reg;
+ struct arch_svm_struct *s = &v->arch.hvm_svm;
+ struct vmcb_struct *vmcb = s->vmcb;
+ struct svm_domain *d = &v->domain->arch.hvm_domain.svm;
+ struct svm_avic_phy_ait_entry entry;
+
+ if ( !svm_avic )
+ return 0;
+
+ vmcb->avic_bk_pg_pa = page_to_maddr(s->avic_bk_pg) & AVIC_HPA_MASK;
+ ma = d->avic_log_ait_mfn;
+ vmcb->avic_log_apic_id = (ma << PAGE_SHIFT) & AVIC_HPA_MASK;
+ ma = d->avic_phy_ait_mfn;
+ vmcb->avic_phy_apic_id = (ma << PAGE_SHIFT) & AVIC_HPA_MASK;
+ vmcb->avic_phy_apic_id |= AVIC_PHY_APIC_ID_MAX;
+
+ dprintk(XENLOG_DEBUG, "SVM: %s: bpa=%#llx, lpa=%#llx, ppa=%#llx\n",
I think you can drop the 'SVM:' part. The __func__ gives enough details.
+ __func__, (unsigned long long)vmcb->avic_bk_pg_pa,
+ (unsigned long long) vmcb->avic_log_apic_id,
+ (unsigned long long) vmcb->avic_phy_apic_id);
Is this also part of the keyboard handler? Perhaps that information should
be presented there?
I'm not sure what you mean by keyboard handler. I assume you mean the
spacing for the indentation the front should align with above line?
Well I would ditch them. And if you really want them then make the
keyboard handler, aka svm_vmcb_dump function.
Thanks,
S.
Ahh.. the xl debug-keys stuff. Got it. No problem. I can ditch this.
S
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
