>>> On 01.11.16 at 11:46, <andrew.coop...@citrix.com> wrote:
> IS_ERR() and IS_ERR_OR_NULL() both return boolean values.
>
> No functional change.
I'm definitely fine with this part. However, ...
> @@ -14,7 +15,10 @@
> */
> #define MAX_ERRNO 4095
>
> -#define IS_ERR_VALUE(x) unlikely((x) >= (unsigned long)-MAX_ERRNO)
> +static inline bool IS_ERR_VALUE(unsigned long x)
> +{
> + return x >= (unsigned long)-MAX_ERRNO;
> +}
... for this one I'd like us to consider following Linux commit
aa00edc128 instead, which I don't think can be achieved by an
inline function alone.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
