>>> On 28.10.16 at 04:37, <feng...@intel.com> wrote: > We should remove the vCPU from the per-cpu blocking list > if it is going to be destroyed.
I think I did raise this question at least once before: Why can it still be on the list in the first place, after patch 2? This is even more odd with ... > --- a/xen/arch/x86/hvm/vmx/vmx.c > +++ b/xen/arch/x86/hvm/vmx/vmx.c > @@ -338,6 +338,7 @@ static void vmx_vcpu_destroy(struct vcpu *v) > * separately here. > */ > vmx_vcpu_disable_pml(v); > + vmx_pi_unblock_vcpu(v); ... the renamed function: A vCPU being destroyed can hardly get unblocked. If the apparently proper solution (removing devices from a domain before destroying its vCPU-s) is not possible or feasible for some reason, then the commit message should say so (and explain why). Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
