Coverity doesn't appear to be able to spot that this is a terminal error path,
but leave a comment to "fix" MISSING_BREAK.
Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com>
---
CC: Jan Beulich <jbeul...@suse.com>
This issue is newly exposed since splitting x86_decode() away from
x86_emulate(). I seem to recall that Coverity has an upper bound of
paths-per-function which it will tolerate (to avoid infinite loops), and the
split allows double the exploration space.
---
xen/arch/x86/x86_emulate/x86_emulate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/x86/x86_emulate/x86_emulate.c
b/xen/arch/x86/x86_emulate/x86_emulate.c
index 78b23a0..32e8b69 100644
--- a/xen/arch/x86/x86_emulate/x86_emulate.c
+++ b/xen/arch/x86/x86_emulate/x86_emulate.c
@@ -1891,7 +1891,7 @@ x86_decode(
switch ( def_ad_bytes )
{
default:
- BUG();
+ BUG(); /* Shouldn't be possible. */
case 2:
if ( in_realmode(ctxt, ops) || (state->regs->eflags & EFLG_VM)
)
break;
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
