>>> On 26.09.16 at 21:45, <shannon.z...@linaro.org> wrote: > On 2016/9/22 8:00, Jan Beulich wrote: >>>>> On 22.09.16 at 14:52, <zhaoshengl...@huawei.com> wrote: >>> --- a/xen/include/public/hvm/params.h >>> +++ b/xen/include/public/hvm/params.h >>> @@ -30,6 +30,7 @@ >>> */ >>> >>> #define HVM_PARAM_CALLBACK_IRQ 0 >>> +#define HVM_PARAM_CALLBACK_IRQ_TYPE_MASK 0xFF00000000000000 >> >> I'd be surprised if this goes through on all compiler versions: This >> is a constant which needs at least a UL suffix (and if intended to >> be usable on 32-bit even a ULL one, which would then get us into >> complications with there not being supposed to be any non-C89 >> constructs in the public headers). > > Do I need to resend this patch or add new one to fix this on top of this > one?
Well, the patch should not go in without this addressed, so yes, I think you will need to send a v7. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
