On 09/19/2016 11:29 AM, Jan Beulich wrote: >>>> On 14.09.16 at 19:37, <joao.m.mart...@oracle.com> wrote: >> --- a/docs/misc/xen-command-line.markdown >> +++ b/docs/misc/xen-command-line.markdown >> @@ -270,7 +270,9 @@ If set, override Xen's default choice for the platform >> timer. >> Having TSC as platform timer requires being explicitly set. This is because >> TSC can only be safely used if CPU hotplug isn't performed on the system. In >> some platforms, "maxcpus" parameter may require further adjustment to the >> -number of online cpus. >> +number of online cpus. When running under platforms that can guarantee a > > ... running on platforms ... > >> +monotonic TSC across sockets you require adjusting "tsc" command line >> parameter > > ... you may want to adjust the ... > >> +parameter to "stable:sockets". > > Redundant "parameter" (I guess the one on the earlier line was meant > to get moved due to line length). Also you say "sockets" here but ... > >> @@ -1508,7 +1510,7 @@ pages) must also be specified via the tbuf\_size >> parameter. >> > `= <integer>` >> >> ### tsc >> -> `= unstable | skewed` >> +> `= unstable | skewed | stable:socket` > > "socket" here - the two really should match. Correct, I will fix this parameter name mismatch, and the spelling mistakes you pointed out above.
>> --- a/xen/arch/x86/time.c >> +++ b/xen/arch/x86/time.c >> @@ -477,6 +477,10 @@ uint64_t ns_to_acpi_pm_tick(uint64_t ns) >> /************************************************************ >> * PLATFORM TIMER 4: TSC >> */ >> +static unsigned int __read_mostly tsc_flags; > > __initdata instead of __read_mostly OK. Joao _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
