>>> On 12.09.16 at 22:18, <daniel.ki...@oracle.com> wrote: > --- a/xen/arch/x86/Rules.mk > +++ b/xen/arch/x86/Rules.mk > @@ -1,6 +1,10 @@ > ######################################## > # x86-specific definitions > > +XEN_IMG_OFFSET = 0x200000
Please prefer := for simple assignments like this one. > +CFLAGS += -DXEN_IMG_OFFSET=$(XEN_IMG_OFFSET) Please move this past ... > CFLAGS += -I$(BASEDIR)/include > CFLAGS += -I$(BASEDIR)/include/asm-x86/mach-generic > CFLAGS += -I$(BASEDIR)/include/asm-x86/mach-default ... these, to keep together with the other -D setting. With those adjustments Acked-by: Jan Beulich <jbeul...@suse.com> Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
