>>> On 11.09.16 at 22:35, <konrad.w...@oracle.com> wrote: > --- a/xen/arch/arm/livepatch.c > +++ b/xen/arch/arm/livepatch.c > @@ -117,6 +117,20 @@ bool_t arch_livepatch_symbol_ok(const struct > livepatch_elf *elf, > return true; > } > > +int arch_livepatch_symbol_check(const struct livepatch_elf *elf, > + const struct livepatch_elf_sym *sym)
Perhaps also better to return bool here? > @@ -255,6 +256,14 @@ static int elf_get_sym(struct livepatch_elf *elf, const > void *data) > > sym[i].sym = s; > sym[i].name = strtab_sec->data + delta; > + /* On ARM we should NEVER see $t* symbols. */ If you really mean to have such an arch-specific comment in common code, may I recommend to use "e.g." or something similar? Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
