>>> On 12.09.16 at 14:29, <andrew.coop...@citrix.com> wrote:
> On 12/09/16 12:41, Jan Beulich wrote:
>>>>> On 12.09.16 at 11:51, <andrew.coop...@citrix.com> wrote:
>>> @@ -205,11 +222,9 @@ void expand_xsave_states(struct vcpu *v, void *dest,
>>> unsigned int size)
>>>
>>> if ( src )
>>> {
>>> - ASSERT((xstate_offsets[index] + xstate_sizes[index]) <= size);
>>> + BUG_ON((xstate_offsets[index] + xstate_sizes[index]) <= size);
>> Surely converting an ASSERT() to BUG_ON() means inverting the
>> relational operator used?
>
> Very true. It is unfortunate that all of this is dead code, and
> impossible to test. I also had half a mind to explicitly #if 0 it out
> to leave people in no illusion that it ever might have been tested.
So with this correct, the patch is then
Reviewed-by: Jan Beulich <jbeul...@suse.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
