On Thu, 2016-09-08 at 09:36 -0600, Jan Beulich wrote: > > > > > > > > > > > > > On 08.09.16 at 07:30, <dongli.zh...@oracle.com> wrote: > > --- a/xen/include/xen/sched.h > > +++ b/xen/include/xen/sched.h > > @@ -474,6 +474,9 @@ struct domain > > unsigned int guest_request_enabled : 1; > > unsigned int guest_request_sync : 1; > > } monitor; > > + > > + /* set to 1 the first time this domain gets scheduled. */ > > + bool_t already_scheduled; > Did you go through and check that there is nothing this information > can already get derived from? I can't immediately point you at > anything, but it feels like there should. > Indeed. And if there isn't and we need to do add our own flagging, isn't there a better way and place where to put it (e.g., what Juergen and Andrew are hinting at)?
> And if indeed there isn't, > then - to extend on someone else's comments (I think it was Dario) > - please use plain bool in new additions. > It's Wei that commented about bool-s use in the patch. :-) Regards, Dario -- <<This happens because I choose it to happen!>> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
