On 07/09/2016 04:33, Konrad Rzeszutek Wilk wrote:
...snip..
+ case R_AARCH64_ABS32:
+ ovf = reloc_data(RELOC_OP_ABS, dest, val, 32);
+ break;
I have noticed that not all the relocations are implemented (e.g
R_AARCH64_ABS16, R_AARCH64_MOVW_*...). I don't think there is anything
preventing the compiler to use them. So is there any particular reasons to
not include them?
I followed the same principle Ross did on x86 - only implement the ones that
the compiler has generated. And that is what I initially had in the v1, but
expanded
it per request.
I can include more, but at what point should I stop?
Good question. My question was more, would it ever be possible to be
generated by the same compiler when applying a patch?
xen/arch/arm/arm64/livepatch.c | 140 +++++++
xen/include/xen/elfstructs.h | 23 ++
lines later and I added them all in.
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel