>>> On 02.09.16 at 19:56, <paul.c....@intel.com> wrote:
> From: Jan Beulich [mailto:jbeul...@suse.com]
> Sent: Friday, September 2, 2016 6:31 AM
>>>> On 19.08.16 at 19:22, <paul.c....@intel.com> wrote:
>> + /* Init alternate p2m data. */
>> + if ( (d->arch.altp2m_eptp = alloc_xenheap_page()) == NULL )
>> + {
>> + rc = -ENOMEM;
>> + goto out;
>> + }
>
> When the epilogue (after the target label) is just a return statement,
> please avoid using goto.
>
> [PAUL] I don't see this code in an epilogue (after the target label).
I don't understand: The function ends like this
out:
return rc;
}
What is it that you don't see here? Again, all I'm asking for is that
in a case like this you simply use "return" instead of the rc
assignment and "goto".
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
