Hi Julien, On 09/01/2016 05:48 PM, Julien Grall wrote: > Hello Sergej, > > On 16/08/16 23:16, Sergej Proskurin wrote: >> This commit exposes the "p2m_*lock" helpers, as they will be used within >> the file ./xen/arch/arm/altp2m.c, as will be shown in the following >> commits. >> >> Signed-off-by: Sergej Proskurin <prosku...@sec.in.tum.de> >> --- >> Cc: Stefano Stabellini <sstabell...@kernel.org> >> Cc: Julien Grall <julien.gr...@arm.com> >> --- >> xen/arch/arm/p2m.c | 12 ++++++------ >> xen/include/asm-arm/p2m.h | 16 ++++++++++++++++ >> 2 files changed, 22 insertions(+), 6 deletions(-) >> >> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c >> index da6c7d4..08114d8 100644 >> --- a/xen/arch/arm/p2m.c >> +++ b/xen/arch/arm/p2m.c >> @@ -62,14 +62,14 @@ static inline bool_t p2m_is_superpage(lpae_t pte, >> unsigned int level) >> return (level < 3) && p2m_mapping(pte); >> } >> >> -static inline void p2m_write_lock(struct p2m_domain *p2m) >> +void p2m_write_lock(struct p2m_domain *p2m) > > This will introduce an overhead when locking the p2m. Those helpers > should be moved a inline in p2m.h and not transform to a functions. >
I did not move the definitions of the functions into the header file to avoid exposing the static function p2m_flush_tlb. However, what I can do is to declare the function prototypes in p2m.h and define them as inline in p2m.c, which should provide the same effect. Best regards, ~Sergej _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
