On 2016/8/25 17:05, Wei Liu wrote: > On Thu, Aug 25, 2016 at 03:54:32PM +0800, Shannon Zhao wrote: >> > >> > >> > On 2016/8/24 20:50, Wei Liu wrote: >>>> > >> - localents[i++] = libxl_defbool_val(info->u.hvm.acpi) ? "1" : >>>> > >> "0"; >>>>> > >> > + localents[i++] = (libxl_defbool_val(info->acpi) && >>>>> > >> > + libxl_defbool_val(info->u.hvm.acpi)) ? >>>>> > >> > "1" : "0"; >>> > > Please provide a function for this. >>> > > >>> > > And the logic doesn't seem right. If the user sets u.hvm.acpi only, >>> > > (s)he should still have ACPI enabled. >> > info->acpi is true by defaut, so if user doesn't set info->acpi while >> > sets u.hvm.acpi only, both u.hvm.acpi and info->acpi will be true IIUC. > OK, that sounds sensible. But please could you document this expectation > in the to-be-created helper function? Thanks Ok, will do.
Thanks, -- Shannon _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel